Skip to content

feat: support RN 0.76 + add example with RNTA #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 31, 2024
Merged

feat: support RN 0.76 + add example with RNTA #538

merged 8 commits into from
Oct 31, 2024

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Oct 17, 2024 •
edited
Loading

Summary

same as #537 but also includes an example app that uses react-native-test-app. You can take it, or ignore it - up to you.

used npx --package react-native-test-app@latest init to create the example. Then copied over the src folder from the old example.

Test Plan

cd rnta-example
yarn install
npx patch-package
cd ios && npx pod-install && cd -

There's a patch for react-native-screens taken from https://github.com/software-mansion/react-native-screens/pull/2407/files#diff-59c313fb0dfe322996885368a5a90d8f8400c2576bb64acc60467c2e79ecd2e9

then build as ususal

@vonovak vonovak changed the title fix: support RN 0.76 feat: support RN 0.76 + add example Oct 17, 2024
@vonovak vonovak mentioned this pull request Oct 17, 2024
Merged
@vonovak vonovak changed the title feat: support RN 0.76 + add example feat: support RN 0.76 + add example with RNTA Oct 17, 2024
@janicduplessis
Copy link
Collaborator

This looks great, gonna take some time to properly review and test in a few days.

@vonovak
Copy link
Contributor Author

vonovak commented Oct 21, 2024

Android build failure will be resolved by using https://github.com/software-mansion/react-native-screens/releases/tag/4.0.0-beta.13

@Rohit3523 Rohit3523 mentioned this pull request Oct 24, 2024
Closed
@shirakaba shirakaba mentioned this pull request Oct 30, 2024
Merged
2 tasks
@janicduplessis
Copy link
Collaborator

@vonovak Looks like rn-screens released a stable version with 0.76 support 3.35.0.

Could you fix the conflicts then I think we can merge this.

@janicduplessis
Copy link
Collaborator

I also have some report of the build still failing on android (#542), if you have the chance could you also check if the new example app works on android?

@vonovak vonovak mentioned this pull request Oct 31, 2024
Closed
@vonovak
Copy link
Contributor Author

vonovak commented Oct 31, 2024 •
edited
Loading

@janicduplessis I installed the .76 - compatible deps and CI is passing. However, I removed the macos example which was just recently added.
RN macos is one version behind the core now, and I'm not sure how well it'll play to have multiple versions of react and etc in one place. Maybe it will work, maybe it won't, maybe there should be 2 examples so that android+ios can run in separation from macos (I'd prefer that)? I felt it's more up to you to decide.

@janicduplessis
Copy link
Collaborator

Since rn macos always seem to he a bit behind rn versions I think we will have to have a different example app sadly.

@janicduplessis janicduplessis merged commit abe1513 into AppAndFlow:main Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janicduplessis janicduplessis janicduplessis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vonovak @janicduplessis